Simplify comparisons and binary operations involving NULL #17088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
optimizer
findepi
force-pushed
the
findepi/simplify-comparisons-and-binary-operations-involving-null-378780
branch
2 times, most recently
from
03173f0 to
ff9b921
Compare
findepi
force-pushed
the
findepi/simplify-comparisons-and-binary-operations-involving-null-378780
branch
2 times, most recently
from
302956d to
6d9d469
Compare
findepi
commented
Aug 8, 2025
| 02)--TableScan: t projection=[x] | ||
| physical_plan | ||
| 01)CoalesceBatchesExec: target_batch_size=8192 | ||
| 02)--FilterExec: x@0 < 5 OR NULL |
Member
Author
There was a problem hiding this comment.
To be followed-up: in a projection context this cannot be simplified, but in a filter context (on top-level of a filter), it can.
Contributor
There was a problem hiding this comment.
Yes, the difference between Filters and Projections for null semantics has come up before. I think currently there is no way to differentiate
There is a ticket that tracks this idea too:
There were optimizations simplifying some arithmetic operations (`*`, `/`, `%` and some bitwise operations) when one operand is constant `NULL`. This can be extended to almost all other binary operators.
findepi
force-pushed
the
findepi/simplify-comparisons-and-binary-operations-involving-null-378780
branch
from
6d9d469 to
e3d60b3
Compare
alamb
approved these changes
Aug 10, 2025
| 02)--TableScan: t projection=[x] | ||
| physical_plan | ||
| 01)CoalesceBatchesExec: target_batch_size=8192 | ||
| 02)--FilterExec: x@0 < 5 OR NULL |
Contributor
There was a problem hiding this comment.
Yes, the difference between Filters and Projections for null semantics has come up before. I think currently there is no way to differentiate
There is a ticket that tracks this idea too:
datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs
Outdated
Show resolved
Hide resolved
xudong963
reviewed
Aug 11, 2025
findepi
deleted the
findepi/simplify-comparisons-and-binary-operations-involving-null-378780
branch
Contributor
|
The extended tests appear to have started failing on main after this PR was merged |
This was referenced Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were optimizations simplifying some arithmetic operations (
*,/,%and some bitwise operations) when one operand is constantNULL. This can be extended to almost all other binary operators.