Skip to content

Perf: Optimize performance of ByteViewGroupValueBuilder on batches with inlined views #16751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

zhuqi-lucas
Copy link
Contributor

@zhuqi-lucas zhuqi-lucas commented Jul 11, 2025

Which issue does this PR close?

Optimize following cases, and add more fast path.

do_append_val_inner
do_equal_to_inner

This is wasteful if there is no data buffer, in which case we can improve the performance.

Also, i do some fast path which is done in arrow-rs.

Rationale for this change

Optimize following cases, and add more fast path.

do_append_val_inner
do_equal_to_inner

What changes are included in this PR?

Optimize following cases, and add more fast path.

do_append_val_inner
do_equal_to_inner

Are these changes tested?

Yes

Are there any user-facing changes?

No

@github-actions github-actions bot added the physical-plan Changes to the physical-plan crate label Jul 11, 2025
@Rachelint
Copy link
Contributor

Thanks @zhuqi-lucas ! How about the benchmark result?

@zhuqi-lucas
Copy link
Contributor Author

zhuqi-lucas commented Jul 12, 2025

Thank you @Rachelint , it seems no performance improvement for clickbench from my local Mac benchmark, i need to investigate further.

@Rachelint
Copy link
Contributor

Rachelint commented Jul 12, 2025

Thank you @Rachelint , it seems no performance improvement for clickbench from my local Mac benchmark, i need to investigate further.

Yes... I made a simple try only in append path before, and also found no obvious improvement... We indeed need further investigation maybe

@zhuqi-lucas zhuqi-lucas marked this pull request as draft July 12, 2025 05:18
@zhuqi-lucas
Copy link
Contributor Author

zhuqi-lucas commented Jul 12, 2025

Thank you @Rachelint , it seems no performance improvement for clickbench from my local Mac benchmark, i need to investigate further.

Yes... I made a simple try only in append path before, and also found no obvious improvement... We indeed need further investigation maybe

I agree, converted it a draft now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
physical-plan Changes to the physical-plan crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize performance of ByteViewGroupValueBuilder on batches with inlined views
2 participants