-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Benchmark for char expression #16743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ajita-asthana for your first contribution
I think it would be great having a bench for char
function.
Thanks @comphead I will fix the linux build failure. |
709ea83
to
a608732
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
Which issue does this PR close?
char
expression #16009Rationale for this change
Add a benchmark to measure char performance, can be reviewed once the char.rs implementation is merged.
What changes are included in this PR?
adds a new file in benches directory.
Are these changes tested?
Are there any user-facing changes?
Nil