Return err if wildcard is not expanded before type coercion

[xudong963]

Rationale for this change

If users use the whole analyzer, they won't encounter the issue. But if only use the TypeCoercionRewriter(Yes, it's me), such as

  if let LogicalPlan::Union(union) = logical_plan  {
      logical_plan = TypeCoercionRewriter::coerce_union(union)?;
  }

and if there is the wildcard in the union, such as the test in the PR, I'll get the error https://github.com/apache/datafusion/blob/main/datafusion/expr/src/logical_plan/plan.rs#L2138.

What changes are included in this PR?

Make the error report early and clear, the current change will directly tell the user what they are missing.

Are these changes tested?

Yes

Are there any user-facing changes?

No

[alamb]

Thanks @xudong963 -- this makes sense to me

cc @jonahgao for your thoughts in case you would also like to review

[alamb]

I thin you can fix the CI test by using assert_contains! rather than checking the exact error message

[jonahgao]

We need to ensure that logical_plan is definitely a union. This could happen if sql_statement_to_plan changes in the future, and then this test would become invalid. We can do it like this：

    let LogicalPlan::Union(union) = logical_plan else {
        panic!("Expected Union plan");
    };
    let err = TypeCoercionRewriter::coerce_union(union)
        .err()
        .unwrap()
        .to_string();
    assert_contains!(
        err,
        "Error during planning: Wildcard should be expanded before type coercion"
    );

[jonahgao]

LGTM, thanks @xudong963 . I have a small suggestion about the test, and we need to fix the clippy error in this PR.

[alamb]

I merged this PR up from main and merged a clippy fix

[xudong963]

thanks @alamb @jonahgao —ill merge it