Support string concat || for StringViewArray

[dharanad]

Which issue does this PR close?

Closes #11766

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

[dharanad]

@alamb I have come up with a naive implementation, and i want to benchmark with current baseline.
Can you guide me on benchmarking strategy and execution?

[alamb]

Thanks @dharanad -- this looks super exciting

Can you guide me on benchmarking strategy and execution?

In terms of benchmarking I would suggest make (in a separate PR) a cargo bench style benchmark, following the model of #12044. A separate PR makes it easier to run the benchmark before/after your changes

[dharanad]

I'm not entirely confident about this approach, as the only method I can think of involves creating a new buffer to hold the concatenated string. Any feedback or guidance on a more efficient solution would be greatly appreciated.

[dharanad]

Weird logictest are passing locally also the error cause is wrong.

[dharanad]

@alamb / @XiangpengHao Can you please help me with a review

[alamb]

I will review this later today

[alamb]

Weird logictest are passing locally also the error cause is wrong.

Likewise I found it strange the tests were passing locally for me.

@dharanad, I took the liberty of merging up from main to get this branch to pass and wrote a few more tests. These tests actually uncovered a bug (value || NULL --> NULL but the previous implementation would return value)

I also made a small performance improvement by avoiding allocating a new String for each row

I also found another bug which I will file separately

Update: filed #12101

[alamb]

Thank you @dharanad 🙏

[alamb]

Thanks again @dharanad

[dharanad]

Thank You @alamb Really appreciate your help

[alamb]

Thank You @alamb Really appreciate your help

Likewise!