Minor: reuse Rows buffer in GroupValuesRows #10980
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #7000
Rationale for this change
While working with @jayzhan211 on #10976 I noticed a TODO that could avoid some allocations
What changes are included in this PR?
Use the API added in apache/arrow-rs#4479 to reuse the temporary
Rows
allocation in the Hash groupingAre these changes tested?
Functionally tested by CI
Performance benchmarks show maybe a slight improvement in performance (but not major)
Details
Are there any user-facing changes?