Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in Cargo.toml (unused manifest key: dependencies.regex.worksapce) #10662

Merged
merged 1 commit into from
May 25, 2024
Merged

Fix typo in Cargo.toml (unused manifest key: dependencies.regex.worksapce) #10662

merged 1 commit into from
May 25, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented May 25, 2024

Which issue does this PR close?

Closes #.

Rationale for this change

When running cargo build locally I see

warning: /Users/andrewlamb/Software/datafusion/datafusion/functions/Cargo.toml: dependency (regex) specified without providing a local path, Git repository, version, or workspace dependency to use. This will be considered an error in future versions
warning: /Users/andrewlamb/Software/datafusion/datafusion/functions/Cargo.toml: unused manifest key: dependencies.regex.worksapce

I think this is due to a typo introduced in #10573

What changes are included in this PR?

Fix typo

Are these changes tested?

Are there any user-facing changes?

@alamb alamb changed the title Fix typo in Cargo.toml Fix typo in Cargo.toml (unused manifest key: dependencies.regex.worksapce) May 25, 2024
@alamb alamb marked this pull request as ready for review May 25, 2024 09:56
goldmedal
goldmedal approved these changes May 25, 2024
View reviewed changes
Copy link
Contributor

@goldmedal goldmedal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops.. my mistake. :P
Many thanks.

@jonahgao jonahgao merged commit 2fc1575 into apache:main May 25, 2024
25 of 26 checks passed
@alamb alamb mentioned this pull request May 25, 2024
Merged
@alamb
Copy link
Contributor Author

alamb commented May 25, 2024

oops.. my mistake. :P Many thanks.

No worries!

@alamb alamb deleted the alamb/fix_cargo_typo branch May 25, 2024 12:51
jayzhan211 pushed a commit to jayzhan211/datafusion that referenced this pull request May 26, 2024
@alamb @jayzhan211
Fix typo in Cargo.toml (apache#10662)
cfd61b2
findepi pushed a commit to findepi/datafusion that referenced this pull request Jul 16, 2024
@alamb @findepi
Fix typo in Cargo.toml (apache#10662)
9ba126c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahgao jonahgao jonahgao approved these changes

@goldmedal goldmedal goldmedal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alamb @goldmedal @jonahgao