Stop most copying LogicalPlan and Exprs in ScalarSubqueryToJoin
#10489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
force-pushed
the
alamb/scalar_subquery_to_join
branch
from
e7867cf
to
d69b128
Compare
alamb
changed the title
ScalarSubqueryToJoinScalarSubqueryToJoin
alamb
commented
May 14, 2024
| match plan { | ||
| LogicalPlan::Filter(filter) => { | ||
| // Optimization: skip the rest of the rule and its copies if |
There was a problem hiding this comment.
Note there is a still a bunch of copying in the actual rewrite logic itself below, but I could not figure out a way to remove it easily as there are several paths that return the original (unmodified) plan for unsupported subqueries
I think we would have to split the check for "is rewrite supported" and the "do the rewrite" logic or something
Given this isn't a tall pole in planning, I don't have any more time to spend on this particular rule so I want to call this good enough
| } else { | ||
| Ok(Transformed::no(expr)) | ||
| } | ||
| // replace column references with entry in map, if it exists |
There was a problem hiding this comment.
Remove some indenting using the api added in #10448, but the logic is the same
|
Thank you for the review @comphead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10294
Rationale for this change
Make the optimizer faster by not copying
What changes are included in this PR?
ScalarSubqueryToJoinwhen there are no ScalarSubqueriesOptimizerRule::rewriteAPIAre these changes tested?
Existing CI
Are there any user-facing changes?
No (maybe minimal performance improvements)