fix NamedStructField should be rewritten in OperatorToFunction in subquery regression (change ApplyFunctionRewrites to use TreeNode API
#10032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
optimizer
alamb
commented
Apr 10, 2024
There was a problem hiding this comment.
@wiedld and I found this while upgrading IOx.
The code in this PR fixes the regression, but I think it could be substantially shorter (and do less copying) by using the TreeNode APIs.
I will work on that later today hopefully
alamb
changed the title
NamedStructField should be rewritten in OperatorToFunction in subqueryNamedStructField should be rewritten in OperatorToFunction in subquery regression
|
I reworked this PR to use the TreeNode API in a546e69 and I am quite happy with how it looks now |
alamb
commented
Apr 10, 2024
| }; | ||
| let name_preserver = NamePreserver::new(&plan); | ||
|
|
||
| plan.map_expressions(|expr| { |
There was a problem hiding this comment.
using the new map_expressions API it is quite straightforward to rewrite these expressions (and it doesn't copy them!)
alamb
commented
Apr 10, 2024
|
|
||
| plan.with_new_exprs(new_expr, new_inputs) |
There was a problem hiding this comment.
this copies the plan + expressions
crepererum
approved these changes
Apr 11, 2024
alamb
changed the title
NamedStructField should be rewritten in OperatorToFunction in subquery regressionNamedStructField should be rewritten in OperatorToFunction in subquery regression (change ApplyFunctionRewrites to use TreeNode API
|
Thanks for the review @crepererum and for the help tracking this down @wiedld |
This was referenced Apr 12, 2024
This was referenced Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10029
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Yes with new tests
Are there any user-facing changes?
Fix regression