-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move abs
to datafusion_functions
#9286
Labels
Comments
alamb
added
enhancement
New feature or request
good first issue
Good for newcomers
labels
Feb 20, 2024
I have tried to make this as well specified as possible and thus I think it would be a good first issue. However, we don't have a huge list of these functions yet so if you hit a snag let us know |
43 tasks
take |
❤️ |
This was referenced Mar 1, 2024
This was referenced Mar 10, 2024
This was referenced Mar 10, 2024
This was referenced Mar 20, 2024
This was referenced Mar 27, 2024
This was referenced Mar 29, 2024
This was referenced Mar 29, 2024
This was referenced Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem or challenge?
Part of #9285 and #8045
The goal is to extract function definitions out of the datafusion core.
Describe the solution you'd like
Move the
abs
function todatafusion-functions
Target location: https://github.com/apache/arrow-datafusion/blob/main/datafusion/functions/src/math
Here is an example function:
isnan
: https://github.com/apache/arrow-datafusion/blob/e1f7b245168c5762135abc4e594bd81c508d7186/datafusion/functions/src/math/nans.rs#L31-L48There is already coverage in https://github.com/apache/arrow-datafusion/blob/main/datafusion/sqllogictest/test_files/scalar.slt
Here are the steps I followed when porting
isnan
:invoke()
function withtodo!()
.cargo check -p datafusion-functions --all-features
compiles successfullyBuiltInScalarFunctions
(source link)cargo check -p datafusion
and the compiler will point out all the places in the code that has logic for this functionsignature
, andreturn_type
and implementation forinvoke()
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: