Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support IS NOT NULL predicates in PruningPredicate #9231

Closed
alamb opened this issue Feb 14, 2024 · 4 comments
Closed

Support IS NOT NULL predicates in PruningPredicate #9231

alamb opened this issue Feb 14, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Feb 14, 2024

Is your feature request related to a problem or challenge?

the PruningPredicate currently does not handle IS NOT NULL predicates

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

@appletreeisyellow added an initial implementation in #9208 but I believe it didn't work in all cases, as described in #9230

@alamb alamb added the enhancement New feature or request label Feb 14, 2024
@guojidan
Copy link
Contributor

take

@guojidan guojidan removed their assignment Feb 18, 2024
@guojidan
Copy link
Contributor

Perhaps @appletreeisyellow is more suitable for handling this issue😄

@alamb
Copy link
Contributor Author

alamb commented Feb 19, 2024

One thing I should have noted in the description here is that I think implementing IS NOT NULL will require a new API to PruningStatistics (the total_row_count) . Conveniently, @appletreeisyellow is adding this API as part of #9171 I think

So in other words, this ticket is likely blocked until #9171 is done

BTW there is a bunch more backstory on #9230

@alamb
Copy link
Contributor Author

alamb commented Apr 22, 2024

I believe that @Ted-Jiang implemented this in #9989 + #10051 so closing this issue

@alamb alamb closed this as completed Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants