Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: bit_and aggregate function is incorrect #6955

Closed
Tracked by #6889
alamb opened this issue Jul 13, 2023 · 2 comments · Fixed by #6957
Closed
Tracked by #6889

Regression: bit_and aggregate function is incorrect #6955

alamb opened this issue Jul 13, 2023 · 2 comments · Fixed by #6957
Labels
bug Something isn't working

Comments

@alamb
Copy link
Contributor

alamb commented Jul 13, 2023

Describe the bug

#6904 introduced a bug where bit_and when a GROUP BY will now return zero always

This was found with the tests added in #6952

To Reproduce

Run test in #6952

External error: query result mismatch:
[SQL] SELECT
  bit_and(c1),
  bit_and(c2),
  bit_and(c3),
  bit_or(c1),
  bit_or(c2),
  bit_or(c3),
  bit_xor(c1),
  bit_xor(c2),
  bit_xor(c3),
  tag
FROM bit_aggregate_functions
GROUP BY tag
ORDER BY tag
[Diff] (-expected|+actual)
-   1 8 11 13 14 11 12 6 11 A
-   33 11 NULL 33 11 NULL 33 11 NULL B
+   0 0 0 13 14 11 12 6 11 A
+   0 0 NULL 33 11 NULL 33 11 NULL B
at tests/sqllogictests/test_files/aggregate.slt:1546

Expected behavior

Test should pass

Additional context

No response

@izveigor
Copy link
Contributor

izveigor commented Jul 13, 2023

@alamb I think the main problem is with the default value. (for bit_and it is -1).

@alamb
Copy link
Contributor Author

alamb commented Jul 13, 2023

@alamb I think the main problem is with the default value. (for bit_and it is -1).

You are 100% correct -- thank you @izveigor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants