Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support filter expression in AggregateExpr(Selective Aggregates) #5608

Closed
mingmwang opened this issue Mar 15, 2023 · 3 comments · Fixed by #5868
Closed

Support filter expression in AggregateExpr(Selective Aggregates) #5608

mingmwang opened this issue Mar 15, 2023 · 3 comments · Fixed by #5868
Labels
enhancement New feature or request

Comments

@mingmwang
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Describe the solution you'd like

Describe alternatives you've considered

Additional context
@mingmwang mingmwang added the enhancement New feature or request label Mar 15, 2023
@mingmwang mingmwang mentioned this issue Mar 15, 2023
Open
@alamb
Copy link
Contributor

alamb commented Mar 15, 2023

What is an example of such a query? Maybe is it what @poonai proposed adding in #3473 / #2214?

@mingmwang
Copy link
Contributor Author

I think this is coming from the ANSI SQL (Selective Aggregates).

https://modern-sql.com/feature/filter
https://popsql.com/learn-sql/postgresql/how-to-use-filter-to-have-multiple-counts-in-postgresql

PostgreSQL, SparkSQL and FlinkSQL all support this usage.

@mingmwang mingmwang changed the title Support filter expression in AggregateExpr Support filter expression in AggregateExpr(Selective Aggregates) Mar 16, 2023
@alamb
Copy link
Contributor

alamb commented Mar 16, 2023

I think it is a dupe of #2214

@alamb alamb mentioned this issue Apr 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Support SQL filter clause for aggregate expressions, add SQL dialect support yjshen/datafusion
2 participants
@alamb @mingmwang