Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor simplify_expressions and expr_simplifier #3934

Closed
HaoYang670 opened this issue Oct 24, 2022 · 0 comments · Fixed by #3951
Closed

Refactor simplify_expressions and expr_simplifier #3934

HaoYang670 opened this issue Oct 24, 2022 · 0 comments · Fixed by #3951
Assignees
Labels
enhancement New feature or request optimizer Optimizer rules

Comments

@HaoYang670
Copy link
Contributor

HaoYang670 commented Oct 24, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Currently, the items related to expression simplification are in simplification_expressions.rs and expr_simplifier, which is somewhat messy.
Some structs such as ConstEvaluator and Simplifier are only used in the simplification_expr, but are public in datafusion_optimizer.

Also, there are some util functions that we should also clean them up.

Describe the solution you'd like
I'd like to create a new mod and put all the things above in it.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request optimizer Optimizer rules
Projects
None yet
1 participant