Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TableProviderFactories need to be async and return a Result to be useful #3866

Closed
avantgardnerio opened this issue Oct 17, 2022 · 0 comments · Fixed by #3867
Closed

TableProviderFactories need to be async and return a Result to be useful #3866

avantgardnerio opened this issue Oct 17, 2022 · 0 comments · Fixed by #3867
Labels
enhancement New feature or request

Comments

@avantgardnerio
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

In a previous PR, I added the concept of TableProviderFactorys, and added a test to show it was possible to do a CREATE EXTERNAL TABLE xxx STORED AS yyy. However, the test was a contrived scenario without the need for network access (as someone pointed out at the time). Real providers will need to do async network access and return an error if that fails.

Describe the solution you'd like

Update the trait signature to support resolution of the issues described above.

Describe alternatives you've considered

An entirely different approach where this is all static and compiled into the protocol and not extensible by third parties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant