Binary expression canonical names are incorrect in some cases

[andygrove]

Describe the bug
Consider the following two expressions, which are not the same:

let expr1 = expr1.and(expr2.or(expr3));
let expr2 = expr1.and(expr2).or(expr3);

They both produce the same string from canonical_name:

a < Int32(1) AND b < Int32(2) OR c < Int32(3)

This is not only confusing when reading plans but could also lead to optimization rules altering plans to have different semantics.

To Reproduce

Expected behavior
They should produce different results:

expr1.and(expr2.or(expr3)) should produce:

a < Int32(1) AND (b < Int32(2) OR c < Int32(3))

expr1.and(expr2).or(expr3) should produce either of these:

a < Int32(1) AND b < Int32(2) OR c < Int32(3)
(a < Int32(1) AND b < Int32(2)) OR c < Int32(3)

There are two ways of resolving this:

• We could just wrap every binary expression in parentheses (easier to implement but makes expressions harder to read)
• We could make the logic precedence-aware so that parentheses are only inserted when needed (preferred)

Additional context

[andygrove]

SQL parser precedence logic for reference: https://github.com/sqlparser-rs/sqlparser-rs/blob/main/src/parser.rs#L1552-L1638