-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chrono crate : specify 0.4.22 as the minimum version due to spurious build failures #3827
Comments
I can reproduce this on mac but not linux |
I ran
This resolved it, so we probably need to specify 0.4.22 as the minimum version |
I blew everything away and started over and this time I no longer see the issue... On the new version after blowing away everything chrono comes in as version = "0.4.22" On my old version that I deleted chrono was version = "0.4.19" |
I love rust ! The only place we check in a Cargo.lock file is here: Because we do not check in a Cargo.lock file anywhere else Because my Cargo.lock file had chrono version 0.4.19 Once you blow target away and start over it reproduces (I think) So some developers will see my error and some developers will not... |
We should increase the declared minimum version of chrono in Datafusion's Cargo.toml to be "0.4.22" if we use features that appear only in versions 0.4.22 or later https://github.com/apache/arrow-datafusion/search?l=TOML&q=chrono |
Proposed fix #3959 |
Compiling datafusion-benchmarks v13.0.0 (/Users/ma/j/tmp06/arrow-datafusion/benchmarks)
error[E0277]: the trait bound
chrono::datetime::DateTime<chrono::offset::utc::Utc>: std::default::Default
is not satisfied--> benchmarks/src/bin/parquet_filter_pushdown.rs:284:24
|
284 | last_modified: Default::default(),
| ^^^^^^^^^^^^^^^^ the trait
std::default::Default
is not implemented forchrono::datetime::DateTime<chrono::offset::utc::Utc>
For more information about this error, try
rustc --explain E0277
.error: could not compile
datafusion-benchmarks
due to previous errorThe text was updated successfully, but these errors were encountered: