Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate Expr manipulation code so it is more discoverable and make it easier to use #3808

Closed
alamb opened this issue Oct 12, 2022 · 0 comments · Fixed by #3810
Closed
Assignees
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Oct 12, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Code to handle manipulating conjunctions (AND) and disjunctions (OR) is sprinkled throughout the codebase making is harder to find as well as leading to duplication

It would also be nice to improve the ergonomics (like distinguishing between owned and unowned variants, for example). We have similar code to this in IOx https://github.com/influxdata/influxdb_iox/blob/95ed41f14063f53e37c10614a77a3d69c6c26188/datafusion_util/src/lib.rs#L41-L45 which I would like to contribute

Describe the solution you'd like

  1. Consolidate manipulation into optimizer/utils for better discoverability, less duplication
  2. Improve the API ergonomics

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@alamb alamb added the enhancement New feature or request label Oct 12, 2022
@alamb alamb self-assigned this Oct 12, 2022
@alamb alamb changed the title Consolidate Expr manipulation code so it is more discoverable Consolidate Expr manipulation code so it is more discoverable and make it easier to use Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant