Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panic at attempt to multiply with overflow when doing math on Decimal128 columns #3437

Closed
Tracked by #3480
kmitchener opened this issue Sep 10, 2022 · 1 comment · Fixed by #4767
Closed
Tracked by #3480
Labels
bug Something isn't working

Comments

@kmitchener
Copy link
Contributor

kmitchener commented Sep 10, 2022

Describe the bug
A clear and concise description of what the bug is.

When changing the TPC-H tests to use Decimals, getting panics with this error:

thread 'sql::subqueries::tpch_q17_correlated' panicked at 'attempt to multiply with overflow', datafusion/physical-expr/src/expressions/binary/kernels_arrow.rs:359:61

To Reproduce
Steps to reproduce the behavior:

Expected behavior
A clear and concise description of what you expected to happen.

Additional context
Add any other context about the problem here.

See #3393 for additional examples where the overflow happens on benchmark queries.

@kmitchener
Copy link
Contributor Author

When fixed, pls un-ignore test tpch_q17_correlated() in core/tests/sql/subqueries.rs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants