Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update limit pushdown rule to support offsets #2550

Closed
andygrove opened this issue May 16, 2022 · 1 comment · Fixed by #2566
Closed

Update limit pushdown rule to support offsets #2550

andygrove opened this issue May 16, 2022 · 1 comment · Fixed by #2566
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@andygrove
Copy link
Member

andygrove commented May 16, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
PR #2521 adds support for OFFSET. The limit push down rule will not push the limit through offset so we should optimize this at some point.

Describe the solution you'd like
If we have offset 5 limit 10 then we should be able to push limit 15 (5 + 10) beneath the offset operator in some cases. There is probably a lot more to this though.

Describe alternatives you've considered
None

Additional context
None

@andygrove andygrove added enhancement New feature or request good first issue Good for newcomers labels May 16, 2022
@Ted-Jiang
Copy link
Member

I will take this. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants