Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize InList implementation with native types rather than ScalarValue #2165

Closed
alamb opened this issue Apr 5, 2022 · 1 comment · Fixed by #4057
Closed

Optimize InList implementation with native types rather than ScalarValue #2165

alamb opened this issue Apr 5, 2022 · 1 comment · Fixed by #4057

Comments

@alamb
Copy link
Contributor

alamb commented Apr 5, 2022

The basic idea is that instead of using ScalarValue which has runtime dispatch overhead, we could use native rust types, like HashSet<u32>, etc. I think that could be a couple times faster.

Originally posted by @Dandandan in #2156 (comment)

@Dandandan
Copy link
Contributor

In addition to higher memory usage and dispatching overhead there are two extra sources of overhead:

  • Having to convert all values from array items to ScalarValue
  • Hashing a Scalarvalue is slower than hashing a native type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants