Skip to content

Add method to SessionStateBuilder that has all the defaut features #14981

@alamb

Description

@alamb
          > Thank you @irenjj -- I think this makes a lot of sense to me

I just wonder if we should provide with_default_features or Default::default implementation for this case as well? wdyt @alamb ?

@milenkovicm I think the usecase of not automatically registering all the default features is to allow creating a SessionState without the defaults (e.g. if you don't want to defaults).

Since there is no method like SessionStateBuilder::clear I am not sure how else one would accomplish this usecase 🤔

than makes sense, what I suggest is to keep all (new) methods as they are just provide new method which will create new with defaults. but I don't have strong opinion about it

Originally posted by @milenkovicm in #14935 (comment)

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions