Skip to content

swap_hash_join is no longer public so comet doesn't compile #13898

@alamb

Description

@alamb

Describe the bug

When upgrading comet to use the latest datafusion pun (andygrove/datafusion-comet#1) it fails to compile with the following error:

error[E0603]: function `swap_hash_join` is private
   --> core/src/execution/planner.rs:56:41
    |
56  |     physical_optimizer::join_selection::swap_hash_join,
    |                                         ^^^^^^^^^^^^^^ private function
    |
note: the function `swap_hash_join` is defined here
   --> /Users/andrewlamb/.cargo/git/checkouts/datafusion-c36d6291a88e48f3/e99e02b/datafusion/core/src/physical_optimizer/join_selection.rs:179:1
    |
179 | / pub(crate) fn swap_hash_join(
180 | |     hash_join: &HashJoinExec,
181 | |     partition_mode: PartitionMode,
182 | | ) -> Result<Arc<dyn ExecutionPlan>> {
    | |___________________________________^

This appears to have been introduced in #13893 from @berkaysynnada

To Reproduce

See andygrove/datafusion-comet#1

Expected behavior

No response

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions