Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[substrait] Replace SessionContext with SessionState #13342

Open
notfilippo opened this issue Nov 10, 2024 · 2 comments · May be fixed by #13343
Open

[substrait] Replace SessionContext with SessionState #13342

notfilippo opened this issue Nov 10, 2024 · 2 comments · May be fixed by #13343
Assignees
Labels
enhancement New feature or request

Comments

@notfilippo
Copy link
Contributor

Is your feature request related to a problem or challenge?

When producing / consuming a substrait plan it's not always practical to pass the SessionContext. Most of the methods used in the crate directly reference SessionContext even though all of them actually make use of the memory in its underlying SessionState.

Describe the solution you'd like

It should be possible to just use the SessionState when producing / consuming substrait plans.

Describe alternatives you've considered

As a next step we could possibly declare a trait with the subset of functions used by the substrait consumer / producer instead of requiring the SessionState object so users could provide their own context to the plan encoding / decoding functions.

Additional context

No response

@notfilippo notfilippo added the enhancement New feature or request label Nov 10, 2024
@notfilippo
Copy link
Contributor Author

take

@vbarua
Copy link
Contributor

vbarua commented Nov 11, 2024

This is complementary to #13318

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants