-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
Describe the bug
The logic for nullability for the return value of array_agg is currently correct.
To Reproduce
The current logic is here:
datafusion/datafusion/physical-expr/src/aggregate/array_agg.rs
Lines 69 to 76 in c7ac8b8
| fn field(&self) -> Result<Field> { | |
| Ok(Field::new_list( | |
| &self.name, | |
| // This should be the same as return type of AggregateFunction::ArrayAgg | |
| Field::new("item", self.input_data_type.clone(), true), | |
| self.nullable, | |
| )) | |
| } |
it returns a list where the nullability depens on the input and the field in the list is always nullable.
Expected behavior
The fields nullability should depend on the input_nullability and the nullability of the list should be false.
Additional context
No response
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working