Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop copying LogicalPlan and Exprs in ScalarSubqueryToJoin #10294

Closed
alamb opened this issue Apr 29, 2024 · 4 comments · Fixed by #10489 or #10500
Closed

Stop copying LogicalPlan and Exprs in ScalarSubqueryToJoin #10294

alamb opened this issue Apr 29, 2024 · 4 comments · Fixed by #10489 or #10500
Assignees

Comments

@alamb
Copy link
Contributor

alamb commented Apr 29, 2024

Is your feature request related to a problem or challenge?

Part of #9637

As part of making the planner faster, we are updating the optimizer passes to avoid copying LogicalPlan and Expr (see #9637)

Describe the solution you'd like

I would like to reduce the amount of copying in this pass (even though it doesn't appear in current profiling)

Describe alternatives you've considered

Apply the model from @Lordworms in #10166 to this pass
2. Update OptimizerRule::supports_rewrite` to return true

  1. Update OptimizerRule to use rewrite
  2. Update the pass itself to not copy the LogicalPlan (ideally using the TreeNode API) - it is implemented for LogicalPlan (API) and Expr (API)

Other examples: #10218

Additional context

@rtadepalli
Copy link

take

@alamb
Copy link
Contributor Author

alamb commented May 13, 2024

Since this one is a bit tricky and I don't see any draft PRs yet, I am going to take a shot at a PR as well

@rtadepalli
Copy link

Well.. I was finishing up going through the Rust book and that took more than expected because other things came up. I'll pick up another ticket, sorry about the delay.

@alamb
Copy link
Contributor Author

alamb commented May 14, 2024

Well.. I was finishing up going through the Rust book and that took more than expected because other things came up. I'll pick up another ticket, sorry about the delay.

No worries -- I think this is a pretty tough first PR to work on. I made a PR to do it here: #10489

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants