-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop copying LogicalPlan and Exprs in ScalarSubqueryToJoin
#10294
Comments
take |
Since this one is a bit tricky and I don't see any draft PRs yet, I am going to take a shot at a PR as well |
Well.. I was finishing up going through the Rust book and that took more than expected because other things came up. I'll pick up another ticket, sorry about the delay. |
No worries -- I think this is a pretty tough first PR to work on. I made a PR to do it here: #10489 |
Is your feature request related to a problem or challenge?
Part of #9637
As part of making the planner faster, we are updating the optimizer passes to avoid copying
LogicalPlan
andExpr
(see #9637)Describe the solution you'd like
I would like to reduce the amount of copying in this pass (even though it doesn't appear in current profiling)
Describe alternatives you've considered
Apply the model from @Lordworms in #10166 to this pass
2. Update OptimizerRule::supports_rewrite` to return true
OptimizerRule
to userewrite
TreeNode
API) - it is implemented forLogicalPlan
(API) andExpr
(API)Other examples: #10218
Additional context
The text was updated successfully, but these errors were encountered: