Skip to content

Commit ed93d8a

Browse files
committed
update args
1 parent 79264c5 commit ed93d8a

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

benchmarks/bench.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -389,7 +389,7 @@ run_clickbench_1() {
389389
RESULTS_FILE="${RESULTS_DIR}/clickbench_1.json"
390390
echo "RESULTS_FILE: ${RESULTS_FILE}"
391391
echo "Running clickbench (1 file) benchmark..."
392-
$CARGO_COMMAND --bin dfbench -- clickbench --iterations 10 --path "${DATA_DIR}/hits.parquet" -o ${RESULTS_FILE}
392+
$CARGO_COMMAND --bin dfbench -- clickbench --iterations 10 --path "${DATA_DIR}/hits.parquet" --queries_path = "${SCRIPT_DIR}/benchmarks/queries/clickbench/queries.sql" -o ${RESULTS_FILE}
393393
}
394394

395395
# Runs the clickbench benchmark with a single large parquet file

benchmarks/src/clickbench.rs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ use crate::{BenchmarkRun, CommonOpt};
3434
/// [1]: https://github.com/ClickHouse/ClickBench
3535
/// [2]: https://github.com/ClickHouse/ClickBench/tree/main/datafusion
3636
#[derive(Debug, StructOpt, Clone)]
37+
#[structopt(verbatim_doc_comment)]
3738
pub struct RunOpt {
3839
/// Query number. If not specified, runs all queries
3940
#[structopt(short, long)]
@@ -47,7 +48,6 @@ pub struct RunOpt {
4748
/// (partitioned, 100 files)
4849
#[structopt(
4950
parse(from_os_str),
50-
required = true,
5151
short = "p",
5252
long = "path",
5353
default_value = "benchmarks/data/hits.parquet"
@@ -57,7 +57,8 @@ pub struct RunOpt {
5757
/// Path to queries.sql (single file)
5858
#[structopt(
5959
parse(from_os_str),
60-
required = true,
60+
short = "qp",
61+
long = "queries_path",
6162
default_value = "benchmarks/queries/clickbench/queries.sql"
6263
)]
6364
queries_path: PathBuf,

0 commit comments

Comments
 (0)