add more tests

Author: Jiayu Liu

datafusion/src/physical_plan/windows.rs

@@ -59,7 +59,7 @@ pub fn create_window_expr(
         })),
         WindowFunction::BuiltInWindowFunction(fun) => {
             Err(DataFusionError::NotImplemented(format!(
-                "window funtion with {:?} not implemented",
+                "window function with {:?} not implemented",
                 fun
             )))
         }

datafusion/src/sql/planner.rs

@@ -2720,6 +2720,16 @@ mod tests {
         quick_test(sql, expected);
     }
 
+    #[test]
+    fn empty_over_multiple() {
+        let sql = "SELECT order_id, MAX(qty) OVER (), CUMe_dist(qty), lag(qty) OVER () from orders";
+        let expected = "\
+        Projection: #order_id, #MAX(qty Multiply Float64(1.1))\
+        \n  WindowAggr: windowExpr=[[MAX(#qty Multiply Float64(1.1))]] partitionBy=[], orderBy=[]\
+        \n    TableScan: orders projection=None";
+        quick_test(sql, expected);
+    }
+
     #[test]
     fn over_partition_by_not_supported() {
         let sql =
@@ -2731,6 +2741,16 @@ mod tests {
         );
     }
 
+    #[test]
+    fn over_order_by_not_supported() {
+        let sql = "SELECT order_id, MAX(delivered) OVER (order BY order_id) from orders";
+        let err = logical_plan(sql).expect_err("query should have failed");
+        assert_eq!(
+            "NotImplemented(\"Unsupported OVER clause (PARTITION BY order_id)\")",
+            format!("{:?}", err)
+        );
+    }
+
     #[test]
     fn only_union_all_supported() {
         let sql = "SELECT order_id from orders EXCEPT SELECT order_id FROM orders";