chore: Upgrade Rust version to 1.90.0 (#17677)

* chore: bump workspace rust version to 1.90.0

* fix clippy errors

* fix clippy errors

* try using dedicate runner temp space

* retrigger

* inspect disk usage

* split build/run

* disable debug info in ci profile

* revert ci changes

Author: rkrishn7

Cargo.toml

@@ -199,6 +199,7 @@ rpath = false
 strip = false            # Retain debug info for flamegraphs
 
 [profile.ci]
+debug = false
 inherits = "dev"
 incremental = false
 

datafusion/core/tests/macro_hygiene/mod.rs

@@ -73,6 +73,7 @@ mod config_field {
     #[test]
     fn test_macro() {
         #[derive(Debug)]
+        #[allow(dead_code)]
         struct E;
 
         impl std::fmt::Display for E {

datafusion/expr-common/src/statistics.rs

@@ -189,7 +189,7 @@ impl Distribution {
     pub fn target_type(args: &[&ScalarValue]) -> Result<DataType> {
         let mut arg_types = args
             .iter()
-            .filter(|&&arg| (arg != &ScalarValue::Null))
+            .filter(|&&arg| arg != &ScalarValue::Null)
             .map(|&arg| arg.data_type());
 
         let Some(dt) = arg_types.next().map_or_else(

datafusion/ffi/src/udwf/partition_evaluator.rs

@@ -86,7 +86,7 @@ pub struct PartitionEvaluatorPrivateData {
 }
 
 impl FFI_PartitionEvaluator {
-    unsafe fn inner_mut(&mut self) -> &mut Box<(dyn PartitionEvaluator + 'static)> {
+    unsafe fn inner_mut(&mut self) -> &mut Box<dyn PartitionEvaluator + 'static> {
         let private_data = self.private_data as *mut PartitionEvaluatorPrivateData;
         &mut (*private_data).evaluator
     }

datafusion/functions-aggregate/src/average.rs

@@ -528,7 +528,7 @@ impl<T: DecimalType + ArrowNumericType + Debug> Accumulator for DecimalAvgAccumu
         self.count += (values.len() - values.null_count()) as u64;
 
         if let Some(x) = sum(values) {
-            let v = self.sum.get_or_insert(T::Native::default());
+            let v = self.sum.get_or_insert_with(T::Native::default);
             self.sum = Some(v.add_wrapping(x));
         }
         Ok(())
@@ -573,7 +573,7 @@ impl<T: DecimalType + ArrowNumericType + Debug> Accumulator for DecimalAvgAccumu
 
         // sums are summed
         if let Some(x) = sum(states[1].as_primitive::<T>()) {
-            let v = self.sum.get_or_insert(T::Native::default());
+            let v = self.sum.get_or_insert_with(T::Native::default);
             self.sum = Some(v.add_wrapping(x));
         }
         Ok(())

datafusion/functions-aggregate/src/bit_and_or_xor.rs

@@ -382,7 +382,7 @@ where
 {
     fn update_batch(&mut self, values: &[ArrayRef]) -> Result<()> {
         if let Some(x) = arrow::compute::bit_or(values[0].as_primitive::<T>()) {
-            let v = self.value.get_or_insert(T::Native::usize_as(0));
+            let v = self.value.get_or_insert_with(|| T::Native::usize_as(0));
             *v = *v | x;
         }
         Ok(())
@@ -427,7 +427,7 @@ where
 {
     fn update_batch(&mut self, values: &[ArrayRef]) -> Result<()> {
         if let Some(x) = arrow::compute::bit_xor(values[0].as_primitive::<T>()) {
-            let v = self.value.get_or_insert(T::Native::usize_as(0));
+            let v = self.value.get_or_insert_with(|| T::Native::usize_as(0));
             *v = *v ^ x;
         }
         Ok(())

datafusion/functions-aggregate/src/sum.rs

@@ -335,7 +335,7 @@ impl<T: ArrowNumericType> Accumulator for SumAccumulator<T> {
     fn update_batch(&mut self, values: &[ArrayRef]) -> Result<()> {
         let values = values[0].as_primitive::<T>();
         if let Some(x) = arrow::compute::sum(values) {
-            let v = self.sum.get_or_insert(T::Native::usize_as(0));
+            let v = self.sum.get_or_insert_with(|| T::Native::usize_as(0));
             *v = v.add_wrapping(x);
         }
         Ok(())

datafusion/physical-expr/src/expressions/binary.rs

@@ -160,7 +160,7 @@ fn boolean_op(
     left: &dyn Array,
     right: &dyn Array,
     op: impl FnOnce(&BooleanArray, &BooleanArray) -> Result<BooleanArray, ArrowError>,
-) -> Result<Arc<(dyn Array + 'static)>, ArrowError> {
+) -> Result<Arc<dyn Array + 'static>, ArrowError> {
     let ll = as_boolean_array(left).expect("boolean_op failed to downcast left array");
     let rr = as_boolean_array(right).expect("boolean_op failed to downcast right array");
     op(ll, rr).map(|t| Arc::new(t) as _)

datafusion/physical-plan/src/joins/sort_merge_join/exec.rs

@@ -362,10 +362,10 @@ impl DisplayAs for SortMergeJoinExec {
                     "SortMergeJoin: join_type={:?}, on=[{}]{}{}",
                     self.join_type,
                     on,
-                    self.filter.as_ref().map_or("".to_string(), |f| format!(
-                        ", filter={}",
-                        f.expression()
-                    )),
+                    self.filter.as_ref().map_or_else(
+                        || "".to_string(),
+                        |f| format!(", filter={}", f.expression())
+                    ),
                     display_null_equality,
                 )
             }

datafusion/physical-plan/src/limit.rs

@@ -105,7 +105,8 @@ impl DisplayAs for GlobalLimitExec {
                     f,
                     "GlobalLimitExec: skip={}, fetch={}",
                     self.skip,
-                    self.fetch.map_or("None".to_string(), |x| x.to_string())
+                    self.fetch
+                        .map_or_else(|| "None".to_string(), |x| x.to_string())
                 )
             }
             DisplayFormatType::TreeRender => {