remove broken core_expressions flag

Author: alamb

.github/workflows/rust.yml

@@ -223,8 +223,6 @@ jobs:
         run: cargo check --profile ci -p datafusion-functions
       - name: Check datafusion-functions (no-default-features)
         run: cargo check --profile ci --no-default-features -p datafusion-functions
-      - name: Check datafusion-functions (core_expressions)
-        run: cargo check --profile ci --no-default-features -p datafusion-functions --features=core_expressions
       - name: Check datafusion-functions (crypto_expressions)
         run: cargo check --profile ci --no-default-features -p datafusion-functions --features=crypto_expressions
       - name: Check datafusion-functions (datetime_expressions)

datafusion/functions/Cargo.toml

@@ -35,14 +35,12 @@ all-features = true
 workspace = true
 
 [features]
-# enable core functions
-core_expressions = []
 crypto_expressions = ["md-5", "sha2", "blake2", "blake3"]
 # enable datetime functions
 datetime_expressions = []
-# Enable encoding by default so the doctests work. In general don't automatically enable all packages.
+# Enable encoding by default so the doctests work.
+# In general don't automatically enable all packages.
 default = [
-    "core_expressions",
     "datetime_expressions",
     "encoding_expressions",
     "math_expressions",
@@ -146,7 +144,6 @@ required-features = ["math_expressions"]
 [[bench]]
 harness = false
 name = "nullif"
-required-features = ["core_expressions"]
 
 [[bench]]
 harness = false

datafusion/functions/src/lib.rs

@@ -98,11 +98,8 @@ pub mod macros;
 pub mod string;
 make_stub_package!(string, "string_expressions");
 
-/// Core datafusion expressions
-/// Enabled via feature flag `core_expressions`
-#[cfg(feature = "core_expressions")]
+/// Core datafusion expressions. These are always enabled
 pub mod core;
-make_stub_package!(core, "core_expressions");
 
 /// Date and time expressions.
 /// Contains functions such as to_timestamp
@@ -147,7 +144,6 @@ pub mod utils;
 
 /// Fluent-style API for creating `Expr`s
 pub mod expr_fn {
-    #[cfg(feature = "core_expressions")]
     pub use super::core::expr_fn::*;
     #[cfg(feature = "crypto_expressions")]
     pub use super::crypto::expr_fn::*;