Skip to content

Commit 98e821c

Browse files
authored
Simplify the return type of sql_select_to_rex() (#14088)
1 parent 41863dd commit 98e821c

File tree

1 file changed

+7
-15
lines changed

1 file changed

+7
-15
lines changed

datafusion/sql/src/select.rs

Lines changed: 7 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -576,10 +576,6 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
576576
projection
577577
.into_iter()
578578
.map(|expr| self.sql_select_to_rex(expr, plan, empty_from, planner_context))
579-
.flat_map(|result| match result {
580-
Ok(vec) => vec.into_iter().map(Ok).collect(),
581-
Err(err) => vec![Err(err)],
582-
})
583579
.collect::<Result<Vec<Expr>>>()
584580
}
585581

@@ -590,7 +586,7 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
590586
plan: &LogicalPlan,
591587
empty_from: bool,
592588
planner_context: &mut PlannerContext,
593-
) -> Result<Vec<Expr>> {
589+
) -> Result<Expr> {
594590
match sql {
595591
SelectItem::UnnamedExpr(expr) => {
596592
let expr = self.sql_to_expr(expr, plan.schema(), planner_context)?;
@@ -599,7 +595,7 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
599595
&[&[plan.schema()]],
600596
&plan.using_columns()?,
601597
)?;
602-
Ok(vec![col])
598+
Ok(col)
603599
}
604600
SelectItem::ExprWithAlias { expr, alias } => {
605601
let select_expr =
@@ -615,7 +611,7 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
615611
Expr::Column(column) if column.name.eq(&name) => col,
616612
_ => col.alias(name),
617613
};
618-
Ok(vec![expr])
614+
Ok(expr)
619615
}
620616
SelectItem::Wildcard(options) => {
621617
Self::check_wildcard_options(&options)?;
@@ -628,7 +624,7 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
628624
planner_context,
629625
options,
630626
)?;
631-
Ok(vec![wildcard_with_options(planned_options)])
627+
Ok(wildcard_with_options(planned_options))
632628
}
633629
SelectItem::QualifiedWildcard(object_name, options) => {
634630
Self::check_wildcard_options(&options)?;
@@ -639,10 +635,7 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
639635
planner_context,
640636
options,
641637
)?;
642-
Ok(vec![qualified_wildcard_with_options(
643-
qualifier,
644-
planned_options,
645-
)])
638+
Ok(qualified_wildcard_with_options(qualifier, planned_options))
646639
}
647640
}
648641
}
@@ -687,13 +680,12 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
687680
.items
688681
.iter()
689682
.map(|item| {
690-
Ok(self.sql_select_to_rex(
683+
self.sql_select_to_rex(
691684
SelectItem::UnnamedExpr(item.expr.clone()),
692685
plan,
693686
empty_from,
694687
planner_context,
695-
)?[0]
696-
.clone())
688+
)
697689
})
698690
.collect::<Result<Vec<_>>>()?;
699691
let planned_replace = PlannedReplaceSelectItem {

0 commit comments

Comments
 (0)