polish

Author: zhuqi-lucas

datafusion/physical-plan/src/sorts/cursor.rs

@@ -369,10 +369,6 @@ impl CursorValues for StringViewArray {
             return false;
         }
 
-        if l_len == 0 && r_len == 0 {
-            return true; // Both are empty strings, so they are equal
-        }
-
         unsafe { GenericByteViewArray::compare_unchecked(l, l_idx, r, r_idx).is_eq() }
     }
 
@@ -394,10 +390,6 @@ impl CursorValues for StringViewArray {
             return false;
         }
 
-        if l_len == 0 && r_len == 0 {
-            return true; // Both are empty strings, so they are equal
-        }
-
         unsafe {
             GenericByteViewArray::compare_unchecked(cursor, idx, cursor, idx - 1).is_eq()
         }

datafusion/physical-plan/src/sorts/merge.rs

@@ -493,13 +493,12 @@ impl<C: CursorValues> SortPreservingMergeStream<C> {
             if self.enable_round_robin_tie_breaker && cmp_node == 1 {
                 match (&self.cursors[winner], &self.cursors[challenger]) {
                     (Some(ac), Some(bc)) => {
-                        let ord = ac.cmp(bc);
-                        if ord.is_eq() {
+                        if ac == bc {
                             self.handle_tie(cmp_node, &mut winner, challenger);
                         } else {
                             // Ends of tie breaker
                             self.round_robin_tie_breaker_mode = false;
-                            if ord.is_gt() {
+                            if ac > bc {
                                 self.update_winner(cmp_node, &mut winner, challenger);
                             }
                         }