updte

Author: alamb

datafusion/core/tests/physical_optimizer/enforce_sorting.rs

@@ -359,7 +359,8 @@ async fn test_do_not_remove_sort_with_limit() -> Result<()> {
     let repartition = repartition_exec(union);
     let physical_plan = sort_preserving_merge_exec(ordering, repartition);
 
-    let test = EnforceSortingTest::new(physical_plan).with_repartition_sorts(true);
+    let test = EnforceSortingTest::new(physical_plan).with_repartition_sorts(true)
+        .with_expected_description("// We should keep the bottom `SortExec`.");
     insta::assert_snapshot!(test.run(), @r#"
     let expected_input = [
         "SortPreservingMergeExec: [nullable_col@0 ASC, non_nullable_col@1 ASC]",
@@ -395,10 +396,10 @@ async fn test_union_inputs_sorted() -> Result<()> {
     let union = union_exec(vec![source2, sort]);
     let physical_plan = sort_preserving_merge_exec(ordering, union);
 
+    // one input to the union is already sorted, one is not.
     let test = EnforceSortingTest::new(physical_plan)
         .with_repartition_sorts(true)
-        // one input to the union is already sorted, one is not.
-        // should not add a sort at the output of the union, input plan should not be changed
+        .with_expected_description("// should not add a sort at the output of the union, input plan should not be changed")
         .with_expect_no_change(true);
 
     insta::assert_snapshot!(test.run(), @r#"
@@ -436,10 +437,10 @@ async fn test_union_inputs_different_sorted() -> Result<()> {
     let union = union_exec(vec![source2, sort]);
     let physical_plan = sort_preserving_merge_exec(ordering, union);
 
+    // one input to the union is already sorted, one is not.
     let test = EnforceSortingTest::new(physical_plan)
         .with_repartition_sorts(true)
-        // one input to the union is already sorted, one is not.
-        // should not add a sort at the output of the union, input plan should not be changed
+        .with_expected_description("// should not add a sort at the output of the union, input plan should not be changed")
         .with_expect_no_change(true);
     insta::assert_snapshot!(test.run(), @r#"
     let expected_input = [
@@ -724,8 +725,7 @@ async fn test_union_inputs_different_sorted7() -> Result<()> {
 
     // Union has unnecessarily fine ordering below it. We should be able to replace them with absolutely necessary ordering.
     let test = EnforceSortingTest::new(physical_plan).with_repartition_sorts(true)
-        .with_expected_description("// Union preserves the inputs ordering and we should not change any of the SortExecs under UnionExec
-");
+        .with_expected_description("// Union preserves the inputs ordering and we should not change any of the SortExecs under UnionExec");
     insta::assert_snapshot!(test.run(), @r#"
     let expected_input = [
         "SortPreservingMergeExec: [nullable_col@0 ASC]",
@@ -784,7 +784,6 @@ async fn test_union_inputs_different_sorted8() -> Result<()> {
 
     // The `UnionExec` doesn't preserve any of the inputs ordering in the
     // example below.
-
     let test = EnforceSortingTest::new(physical_plan)
         .with_repartition_sorts(true)
         .with_expected_description(