Skip to content

Commit 7d1cf91

Browse files
authored
minor: change some plan_err to exec_err (#7996)
* minor: change some plan_err to exec_err Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * change unreachable code to internal error Signed-off-by: Ruihang Xia <waynestxia@gmail.com> --------- Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
1 parent e98625c commit 7d1cf91

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

datafusion/physical-expr/src/expressions/column.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ use arrow::{
2828
datatypes::{DataType, Schema},
2929
record_batch::RecordBatch,
3030
};
31-
use datafusion_common::plan_err;
3231
use datafusion_common::{internal_err, DataFusionError, Result};
3332
use datafusion_expr::ColumnarValue;
3433

@@ -176,7 +175,7 @@ impl PhysicalExpr for UnKnownColumn {
176175

177176
/// Evaluate the expression
178177
fn evaluate(&self, _batch: &RecordBatch) -> Result<ColumnarValue> {
179-
plan_err!("UnKnownColumn::evaluate() should not be called")
178+
internal_err!("UnKnownColumn::evaluate() should not be called")
180179
}
181180

182181
fn children(&self) -> Vec<Arc<dyn PhysicalExpr>> {

datafusion/physical-expr/src/expressions/no_op.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ use arrow::{
2828

2929
use crate::physical_expr::down_cast_any_ref;
3030
use crate::PhysicalExpr;
31-
use datafusion_common::{plan_err, DataFusionError, Result};
31+
use datafusion_common::{internal_err, DataFusionError, Result};
3232
use datafusion_expr::ColumnarValue;
3333

3434
/// A place holder expression, can not be evaluated.
@@ -65,7 +65,7 @@ impl PhysicalExpr for NoOp {
6565
}
6666

6767
fn evaluate(&self, _batch: &RecordBatch) -> Result<ColumnarValue> {
68-
plan_err!("NoOp::evaluate() should not be called")
68+
internal_err!("NoOp::evaluate() should not be called")
6969
}
7070

7171
fn children(&self) -> Vec<Arc<dyn PhysicalExpr>> {

datafusion/physical-expr/src/sort_expr.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ use crate::PhysicalExpr;
2525

2626
use arrow::compute::kernels::sort::{SortColumn, SortOptions};
2727
use arrow::record_batch::RecordBatch;
28-
use datafusion_common::plan_err;
28+
use datafusion_common::exec_err;
2929
use datafusion_common::{DataFusionError, Result};
3030
use datafusion_expr::ColumnarValue;
3131

@@ -66,7 +66,7 @@ impl PhysicalSortExpr {
6666
let array_to_sort = match value_to_sort {
6767
ColumnarValue::Array(array) => array,
6868
ColumnarValue::Scalar(scalar) => {
69-
return plan_err!(
69+
return exec_err!(
7070
"Sort operation is not applicable to scalar value {scalar}"
7171
);
7272
}

0 commit comments

Comments
 (0)