Minor: add ticket reference and fmt (#11805)

alamb · web-flow · commit 1d3bdbe14fd0 · 2024-08-05T08:16:36.000+08:00
diff --git a/datafusion/proto/src/physical_plan/mod.rs b/datafusion/proto/src/physical_plan/mod.rs
@@ -489,7 +489,13 @@ impl AsExecutionPlan for protobuf::PhysicalPlanNode {
 
                                             // TODO: approx_percentile_cont and approx_percentile_cont_weight are not supported for UDAF from protobuf yet.
                                             // TODO: `order by` is not supported for UDAF yet
-                                            AggregateExprBuilder::new(agg_udf, input_phy_expr).schema(Arc::clone(&physical_schema)).name(name).with_ignore_nulls(agg_node.ignore_nulls).with_distinct(agg_node.distinct).build()
+                                            // https://github.com/apache/datafusion/issues/11804
+                                            AggregateExprBuilder::new(agg_udf, input_phy_expr)
+                                                .schema(Arc::clone(&physical_schema))
+                                                .name(name)
+                                                .with_ignore_nulls(agg_node.ignore_nulls)
+                                                .with_distinct(agg_node.distinct)
+                                                .build()
                                         }
                                     }
                                 }).transpose()?.ok_or_else(|| {

Original file line number	Diff line number	Diff line change
`@@ -489,7 +489,13 @@ impl AsExecutionPlan for protobuf::PhysicalPlanNode {`
`489`	`489`
`490`	`490`	`// TODO: approx_percentile_cont and approx_percentile_cont_weight are not supported for UDAF from protobuf yet.`
`491`	`491`	// TODO: `order by` is not supported for UDAF yet
`492`		`- AggregateExprBuilder::new(agg_udf, input_phy_expr).schema(Arc::clone(&physical_schema)).name(name).with_ignore_nulls(agg_node.ignore_nulls).with_distinct(agg_node.distinct).build()`
	`492`	`+ // https://github.com/apache/datafusion/issues/11804`
	`493`	`+ AggregateExprBuilder::new(agg_udf, input_phy_expr)`
	`494`	`+ .schema(Arc::clone(&physical_schema))`
	`495`	`+ .name(name)`
	`496`	`+ .with_ignore_nulls(agg_node.ignore_nulls)`
	`497`	`+ .with_distinct(agg_node.distinct)`
	`498`	`+ .build()`
`493`	`499`	`}`
`494`	`500`	`}`
`495`	`501`	`}).transpose()?.ok_or_else(\|\| {`