review suggestion

mbwhite · mbwhite · commit 188235b9f18c · 2024-12-09T16:46:49.000Z
Signed-off-by: MBWhite &lt;whitemat@uk.ibm.com&gt;
diff --git a/datafusion/substrait/src/logical_plan/producer.rs b/datafusion/substrait/src/logical_plan/producer.rs
@@ -2430,7 +2430,7 @@ mod test {
 
         match &expression.rex_type {
             Some(RexType::Selection(field_ref)) => {
-                assert_ne!(field_ref.root_type, None);
+                assert_eq!(field_ref.root_type.clone().expect("root type should be set"), RootType::RootReference(RootReference {}));
             }
 
             _ => panic!("Should not be anything other than field reference"),

Original file line number	Diff line number	Diff line change
`@@ -2430,7 +2430,7 @@ mod test {`
`2430`	`2430`
`2431`	`2431`	`match &expression.rex_type {`
`2432`	`2432`	`Some(RexType::Selection(field_ref)) => {`
`2433`		`- assert_ne!(field_ref.root_type, None);`
	`2433`	`+ assert_eq!(field_ref.root_type.clone().expect("root type should be set"), RootType::RootReference(RootReference {}));`
`2434`	`2434`	`}`
`2435`	`2435`
`2436`	`2436`	`_ => panic!("Should not be anything other than field reference"),`