Apply suggestions from code review

Author: ozankabak

datafusion/physical-expr/src/aggregate.rs

@@ -42,10 +42,8 @@ use crate::expressions::Column;
 
 use arrow::datatypes::{DataType, Field, Schema, SchemaRef};
 use arrow_schema::SortOptions;
-use datafusion_common::ScalarValue;
-use datafusion_common::{internal_err, not_impl_err, Result};
-use datafusion_expr::ReversedUDAF;
-use datafusion_expr::{AggregateExprSetMonotonicity, AggregateUDF};
+use datafusion_common::{internal_err, not_impl_err, ScalarValue, Result};
+use datafusion_expr::{AggregateExprSetMonotonicity, AggregateUDF, ReversedUDAF};
 use datafusion_expr_common::accumulator::Accumulator;
 use datafusion_expr_common::groups_accumulator::GroupsAccumulator;
 use datafusion_expr_common::type_coercion::aggregates::check_arg_count;
@@ -547,7 +545,7 @@ impl AggregateFunctionExpr {
         self.fun.inner().set_monotonicity(data_type)
     }
 
-    /// Returns PhysicalSortExpr based on monotonicity of the function
+    /// Returns `PhysicalSortExpr` based on the set monotonicity of the function.
     pub fn get_result_ordering(&self, aggr_func_idx: usize) -> Option<PhysicalSortExpr> {
         // If the aggregate expressions are set-monotonic, the output data is
         // naturally ordered with it per group or partition.

datafusion/physical-expr/src/window/aggregate.rs

@@ -32,8 +32,7 @@ use crate::{reverse_order_bys, EquivalenceProperties, PhysicalExpr};
 use arrow::array::Array;
 use arrow::record_batch::RecordBatch;
 use arrow::{array::ArrayRef, datatypes::Field};
-use datafusion_common::ScalarValue;
-use datafusion_common::{DataFusionError, Result};
+use datafusion_common::{DataFusionError, ScalarValue, Result};
 use datafusion_expr::{Accumulator, WindowFrame};
 use datafusion_physical_expr_common::sort_expr::LexOrdering;
 

datafusion/physical-expr/src/window/standard.rs

@@ -65,7 +65,7 @@ impl StandardWindowExpr {
         &self.expr
     }
 
-    /// Adds any equivalent orderings generated by the `self.expr` to `builder`.
+    /// Adds any equivalent orderings generated by `self.expr` to `builder`.
     ///
     /// If `self.expr` doesn't have an ordering, ordering equivalence properties
     /// are not updated. Otherwise, ordering equivalence properties are updated
@@ -270,7 +270,8 @@ impl WindowExpr for StandardWindowExpr {
     }
 }
 
-/// Adds new ordering expression into the existing ordering equivalence class based on partition by information.
+/// Adds a new ordering expression into existing ordering equivalence class(es) based on
+/// PARTITION BY information (if it exists).
 pub(crate) fn add_new_ordering_expr_with_partition_by(
     eqp: &mut EquivalenceProperties,
     expr: PhysicalSortExpr,