Remove implicit cloning

Author: alamb

datafusion/core/src/physical_plan/windows/mod.rs

@@ -199,7 +199,7 @@ pub(crate) fn calc_requirements(
     for sort_expr in orderby_sort_exprs {
         let contains = sort_reqs.iter().any(|e| sort_expr.expr.eq(e.expr()));
         if !contains {
-            sort_reqs.push(PhysicalSortRequirement::from(sort_expr));
+            sort_reqs.push(PhysicalSortRequirement::from(sort_expr.clone()));
         }
     }
     // Convert empty result to None. Otherwise wrap result inside Some()

datafusion/physical-expr/src/sort_expr.rs

@@ -112,24 +112,12 @@ impl From<PhysicalSortRequirement> for PhysicalSortExpr {
     }
 }
 
-impl From<&PhysicalSortRequirement> for PhysicalSortExpr {
-    fn from(value: &PhysicalSortRequirement) -> Self {
-        value.clone().into_sort_expr()
-    }
-}
-
 impl From<PhysicalSortExpr> for PhysicalSortRequirement {
     fn from(value: PhysicalSortExpr) -> Self {
         PhysicalSortRequirement::new(value.expr, Some(value.options))
     }
 }
 
-impl From<&PhysicalSortExpr> for PhysicalSortRequirement {
-    fn from(value: &PhysicalSortExpr) -> Self {
-        PhysicalSortRequirement::from(value.clone())
-    }
-}
-
 impl PartialEq for PhysicalSortRequirement {
     fn eq(&self, other: &PhysicalSortRequirement) -> bool {
         self.options == other.options && self.expr.eq(&other.expr)
@@ -190,13 +178,14 @@ impl PhysicalSortRequirement {
     /// Returns [`PhysicalSortRequirement`] that requires the exact
     /// sort of the [`PhysicalSortExpr`]s in `ordering`
     ///
-    /// This method is designed for
+    /// This method takes `&'a PhysicalSortExpr` to make it easy to
     /// use implementing [`ExecutionPlan::required_input_ordering`].
     pub fn from_sort_exprs<'a>(
         ordering: impl IntoIterator<Item = &'a PhysicalSortExpr>,
     ) -> Vec<PhysicalSortRequirement> {
         ordering
             .into_iter()
+            .cloned()
             .map(PhysicalSortRequirement::from)
             .collect()
     }