Skip to content

fix for queries with both order by and limit #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2018

Conversation

virattara
Copy link
Contributor

This PR adds support for queries like:
SELECT col_name FROM table_name WHERE id <= 100 ORDER BY date_reg LIMIT 5

@coveralls
Copy link

coveralls commented Oct 12, 2018

Pull Request Test Coverage Report for Build 58

  • 20 of 23 (86.96%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 82.275%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tests/sqlparser_generic.rs 14 15 93.33%
src/sqlparser.rs 6 8 75.0%
Totals Coverage Status
Change from base Build 53: 0.3%
Covered Lines: 2098
Relevant Lines: 2550

💛 - Coveralls

@andygrove andygrove merged commit 633aeb9 into apache:master Oct 14, 2018
jmhain added a commit to jmhain/sqlparser-rs that referenced this pull request Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants