Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Snowflake account privileges #1666

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yoavcloud
Copy link
Contributor

This PR mostly handles the following part of the GRANT syntax on Snowflake: https://docs.snowflake.com/en/sql-reference/sql/grant-privilege

GRANT { globalPrivileges | ALL [ PRIVILEGES ] } ON ACCOUNT TO [ ROLE ] <role_name> [ WITH GRANT OPTION ]

Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yoavcloud! Left one minor comment

#[derive(Debug, Clone, PartialEq, PartialOrd, Eq, Ord, Hash)]
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
#[cfg_attr(feature = "visitor", derive(Visit, VisitMut))]
pub enum ActionCreateObjectType {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a link to the docs for the introduced enums? I'm thinking since there's a lot of them, especially in the parsing code it'll be useful to know where the syntax is coming from for reference

@alamb
Copy link
Contributor

alamb commented Jan 19, 2025

Hi @yoavcloud -- thank you for all these PRs / features 🙏

Given you are so active in the project and now are quite familar with the code, perhaps you might be interested in helping review other contributor PRs as well? To do so just leave a review and then tag @iffyio and/or myself

The goal would would be to get the PR to point where we can just approve it and merge. I think the big things to check for would be test coverage and style consistency with the rest of the crate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants