Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Stop passing Java config map into native createPlan #1101

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andygrove
Copy link
Member

Which issue does this PR close?

Part of #1098

Rationale for this change

We were constructing a Java map containing 5 configs and passing that into native and then extracting those configs. This is expensive compared to just passing the 5 configs as parameters.

This config mechanism also supported passing arbitrary DataFusion configs into the native context but I am not aware of anyone using this feature, and perhaps there is a cleaner way to do this if we want to add it back.

What changes are included in this PR?

Just some refactoring to make createPlan a little more efficient.

How are these changes tested?

Existing tests.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.28%. Comparing base (b74bfe4) to head (3ea852f).
Report is 6 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1101      +/-   ##
============================================
- Coverage     34.33%   34.28%   -0.06%     
+ Complexity      898      890       -8     
============================================
  Files           115      115              
  Lines         42986    42922      -64     
  Branches       9369     9378       +9     
============================================
- Hits          14761    14717      -44     
+ Misses        25361    25327      -34     
- Partials       2864     2878      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants