Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable all ignored Spark SQL tests for Spark 3.5.1 #617

Closed
andygrove opened this issue Jul 1, 2024 · 1 comment · Fixed by #676
Closed

Enable all ignored Spark SQL tests for Spark 3.5.1 #617

andygrove opened this issue Jul 1, 2024 · 1 comment · Fixed by #676
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@andygrove
Copy link
Member

andygrove commented Jul 1, 2024

What is the problem the feature request solves?

PR #603 enabled Spark SQL tests for Spark 3.5.1 but some tests are ignored with TODO comments for fixing Comet. This issue is to track enabling all of them.

There may be some overlap between this issue and #551.

The following suites have comments linking to this issue for newly ignored tests for 3.5.1

modified:   sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileMetadataStructSuite.scala
modified:   sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileMetadataStructRowIndexSuite.scala
modified:   sql/core/src/test/scala/org/apache/spark/sql/sources/BucketedReadSuite.scala
modified:   sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingJoinSuite.scala

Describe the potential solution

No response

Additional context

No response

@andygrove andygrove added the enhancement New feature or request label Jul 1, 2024
@andygrove andygrove self-assigned this Jul 16, 2024
@andygrove andygrove added this to the 0.1.0 milestone Jul 16, 2024
@andygrove
Copy link
Member Author

andygrove commented Jul 17, 2024

This is the next failure to resolve:

- bucket coalescing is applied when join expressions match with partitioning expressions *** FAILED *** (426 milliseconds)
ArrayBuffer() had length 0 instead of expected length 1 (BucketedReadSuite.scala:1068)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant