Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back to released version of DataFusion and arrow-rs after Arrow Java 16 is released #248

Closed
Tracked by #369
viirya opened this issue Apr 8, 2024 · 8 comments · Fixed by #403
Closed
Tracked by #369
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@viirya
Copy link
Member

viirya commented Apr 8, 2024

What is the problem the feature request solves?

In #239, we moved to use specified forked of DataFusion and arrow-rs as a temporary workaround to the Arrow Java bug which sends invalid offset buffers through C Data Interface.

The fix to the bug was merged to Arrow Java. Once Arrow Java 16 is released, we should move back to released versions of DataFusion and arrow-rs.

Describe the potential solution

No response

Additional context

No response

@andygrove
Copy link
Member

Arrow 16 has now been released:

https://arrow.apache.org/release/16.0.0.html

@viirya
Copy link
Member Author

viirya commented Apr 25, 2024

Got it. Thanks.

@viirya viirya self-assigned this Apr 26, 2024
@viirya
Copy link
Member Author

viirya commented Apr 26, 2024

I would like to hold this until #250 is merged. Assigned to myself.

@andygrove
Copy link
Member

@viirya Is there anything stopping us from depending on the datafusion repo directly now (once apache/datafusion#10702 is merged) rather than your fork?

@viirya
Copy link
Member Author

viirya commented May 30, 2024

Let me try to switch to official DataFusion repo.

@viirya
Copy link
Member Author

viirya commented May 30, 2024

There are some changes from latest DataFusion repo. I'm working on to update Comet with it.

@andygrove
Copy link
Member

The release vote for arrow-rs 52 has started, and there is a draft PR in DataFusion to upgrade to this version:

apache/datafusion#10765

@viirya
Copy link
Member Author

viirya commented Jun 3, 2024

Cool. I will update the PR accordingly once we get DataFusion and arrow-rs releases.

@andygrove andygrove added this to the 0.1.0 milestone Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants