Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump DataFusion version #453

Merged
merged 11 commits into from
Oct 28, 2022
Merged

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented Oct 26, 2022

Which issue does this PR close?

N/A

Rationale for this change

I would like to test some of the bug fixes in DF and see if more of the benchmark queries now work.

What changes are included in this PR?

Use DF just before apache/datafusion#3907 because we are talking about rolling that back.

Are there any user-facing changes?

I don't know yet

@andygrove andygrove marked this pull request as draft October 26, 2022 15:06
@Dandandan
Copy link
Contributor

Dandandan commented Oct 26, 2022

Looks great - I went ahead and fixed the cargo.toml bug - this uncovered some necessary changes needed in the python crate.

I believe the other failure is apache/datafusion#3953

@Dandandan
Copy link
Contributor

Dandandan commented Oct 26, 2022

This brings also some perf improvements to q7 and q19. q15 now runs too 🥳

@yahoNanJing
Copy link
Contributor

Looks great. One more thing about the format of the datafusion.proto, is there any standard format so that future PRs will not be influenced by the format change?

@Dandandan
Copy link
Contributor

Dandandan commented Oct 27, 2022

I also pushed changes to compile python and updated revs to include apache/datafusion#3978
Let's see if everything is green now.

@Dandandan Dandandan marked this pull request as ready for review October 27, 2022 06:50
@Dandandan
Copy link
Contributor

The earlier failing test passes now too

@andygrove
Copy link
Member Author

Thanks @Dandandan !

@andygrove
Copy link
Member Author

Looks great. One more thing about the format of the datafusion.proto, is there any standard format so that future PRs will not be influenced by the format change?

Filed #462 for this

@andygrove
Copy link
Member Author

LGTM. I cannot approve because I created the PR.

@Dandandan Dandandan merged commit 1f80a96 into apache:master Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants