Skip to content

Commit 353b33a

Browse files
committed
Unify Node.js installs for xarches
nodejs can now be installed like it is on x86_64 so avoid a spacial case. In fact the special case prevented building a multi-arch image for ubuntu-jammy. Also clean up a left-over var from a removed feature.
1 parent f1a60ee commit 353b33a

File tree

2 files changed

+5
-11
lines changed

2 files changed

+5
-11
lines changed

bin/apt-dependencies.sh

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -84,15 +84,12 @@ else
8484
fi
8585

8686
# Node.js
87-
if [ "${ARCH}" == "ppc64le" -o "${ARCH}" == "s390x" ]; then
88-
apt-get install --no-install-recommends -y nodejs npm
89-
else
90-
wget https://deb.nodesource.com/setup_${NODEVERSION}.x
91-
if /bin/bash setup_${NODEVERSION}.x; then
92-
apt-get install --no-install-recommends -y nodejs
93-
fi
94-
rm setup_${NODEVERSION}.x
87+
wget https://deb.nodesource.com/setup_${NODEVERSION}.x
88+
if /bin/bash setup_${NODEVERSION}.x; then
89+
apt-get install --no-install-recommends -y nodejs
9590
fi
91+
rm setup_${NODEVERSION}.x
92+
9693
# maybe install node from scratch if pkg install failed...
9794
if [ -z "$(which node)" ]; then
9895
apt-get purge -y nodejs || true
@@ -120,8 +117,6 @@ EOF
120117
apt-get install --no-install-recommends -y ./nodejs*.deb
121118
rm nodejs-control nodejs*deb
122119
fi
123-
# update to latest npm
124-
npm install npm@latest -g --unsafe-perm
125120

126121
# rest of python dependencies
127122
pip3 --default-timeout=10000 install --upgrade sphinx_rtd_theme nose requests hypothesis==3.79.0

build.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ SCRIPTPATH="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
4949
DEBIANS="debian-buster debian-bullseye"
5050
UBUNTUS="ubuntu-bionic ubuntu-focal ubuntu-jammy"
5151
CENTOSES="centos-7 rockylinux-8 rockylinux-9"
52-
ERLANGALL_BASE="debian-bullseye"
5352
XPLAT_BASE="debian-bullseye"
5453
XPLAT_ARCHES="arm64v8 ppc64le s390x"
5554
PASSED_BUILDARGS="$buildargs"

0 commit comments

Comments
 (0)