Skip to content

Conversation

@kumo01GitHub
Copy link
Contributor

@kumo01GitHub kumo01GitHub commented Aug 2, 2025

Platforms affected

n/a

Motivation and Context

Use latest @cordova/eslint-config

Description

  • Bump @cordova/eslint-config@6.0.0
  • Fix lint warnings
  • Bump cordova-android requirements to 12.0.0 because some fixtures for lint warnings require ES6.

Testing

npm t

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu
Copy link
Member

erisu commented Nov 18, 2025

@kumo01GitHub ( cc @breautek )

I think we should still prepare a major release before merging this PR in.

Do you agree?

When looking at the engine requirements in plugin.xml and package.json we can see the following cordova-android support:

<engine name="cordova-android" version=">=7.0.0" />

I suspect Android 4.4 would be problematic...

Maybe we should bump major and increase the version requirement to >=12.0.0.

Any thoughts on this?

@breautek
Copy link
Contributor

@kumo01GitHub ( cc @breautek )

I think we should still prepare a major release before merging this PR in.

Do you agree?

When looking at the engine requirements in plugin.xml and package.json we can see the following cordova-android support:

<engine name="cordova-android" version=">=7.0.0" />

I suspect Android 4.4 would be problematic...

Maybe we should bump major and increase the version requirement to >=12.0.0.

Any thoughts on this?

I think you bring up a good point actually. I didn't check cordova-android engine requirements. But yah Android 4.4 is locked to like Chrome 30 something. Android 5 (or 5.1 on some vendors) introduced updatable webviews, but that is limited to around chrome 70ish iirc.

@kumo01GitHub kumo01GitHub changed the title chore: bump eslint chore!: bump eslint Nov 22, 2025
@kumo01GitHub
Copy link
Contributor Author

kumo01GitHub commented Nov 22, 2025

Do you agree?

@erisu @breautek
I do agree and any other opinions. I updated plugin.xml and description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants