-
Notifications
You must be signed in to change notification settings - Fork 430
chore!: bump eslint #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
chore!: bump eslint #213
Conversation
|
@kumo01GitHub ( cc @breautek ) I think we should still prepare a major release before merging this PR in. Do you agree? When looking at the engine requirements in <engine name="cordova-android" version=">=7.0.0" />I suspect Android 4.4 would be problematic... Maybe we should bump major and increase the version requirement to Any thoughts on this? |
I think you bring up a good point actually. I didn't check cordova-android engine requirements. But yah Android 4.4 is locked to like Chrome 30 something. Android 5 (or 5.1 on some vendors) introduced updatable webviews, but that is limited to around chrome 70ish iirc. |
Platforms affected
n/a
Motivation and Context
Use latest @cordova/eslint-config
Description
cordova-androidrequirements to 12.0.0 because some fixtures for lint warnings require ES6.Testing
npm tChecklist
(platform)if this change only applies to one platform (e.g.(android))