Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(ios): add console output for simulator selection #1036

Merged
merged 1 commit into from
Jan 19, 2021

Conversation

NiklasMerz
Copy link
Member

Platforms affected

iOS

Motivation and Context

Closes #594

Description

Just add two more log messages for how simulators are chosen.

Testing

Manual

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

Copy link
Member

@timbru31 timbru31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint is not yet happy. :)

@codecov-io
Copy link

codecov-io commented Dec 7, 2020

Codecov Report

Merging #1036 (4703c1e) into master (e92f653) will increase coverage by 74.84%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1036       +/-   ##
===========================================
+ Coverage        0   74.84%   +74.84%     
===========================================
  Files           0       13       +13     
  Lines           0     1721     +1721     
===========================================
+ Hits            0     1288     +1288     
- Misses          0      433      +433     
Impacted Files Coverage Δ
bin/templates/scripts/cordova/lib/build.js 52.12% <100.00%> (ø)
...emplates/scripts/cordova/lib/listEmulatorImages.js 100.00% <0.00%> (ø)
bin/templates/scripts/cordova/lib/PodsJson.js 95.04% <0.00%> (ø)
bin/templates/scripts/cordova/Api.js 71.53% <0.00%> (ø)
bin/templates/scripts/cordova/lib/projectFile.js 95.00% <0.00%> (ø)
bin/templates/scripts/cordova/lib/Podfile.js 73.20% <0.00%> (ø)
bin/templates/scripts/cordova/lib/check_reqs.js 45.09% <0.00%> (ø)
...ates/scripts/cordova/lib/plugman/pluginHandlers.js 90.05% <0.00%> (ø)
bin/templates/scripts/cordova/lib/listDevices.js 100.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e92f653...4703c1e. Read the comment docs.

@dpogue dpogue added this to the 6.next milestone Jan 19, 2021
@dpogue dpogue merged commit fb5fd2f into apache:master Jan 19, 2021
@NiklasMerz NiklasMerz deleted the sim branch January 20, 2021 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More insight into device/simulator deployment
5 participants