misc: fix spelling

[jbampton]

Description

This PR fixes spelling

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

Attention: 52 lines in your changes are missing coverage. Please review.

Comparison is base (9773ba3) 29.20% compared to head (4a149f4) 28.46%.
Report is 122 commits behind head on main.

Files	Patch %	Lines
.../xenserver/resource/XenServerStorageProcessor.java	0.00%	7 Missing ⚠️
...ud/hypervisor/kvm/storage/KVMStorageProcessor.java	0.00%	4 Missing ⚠️
...n/java/com/cloud/vm/VirtualMachineManagerImpl.java	0.00%	3 Missing ⚠️
...ypervisor/ovm3/resources/Ovm3StorageProcessor.java	0.00%	3 Missing ⚠️
...e/resource/StorageSubsystemCommandHandlerBase.java	50.00%	1 Missing and 1 partial ⚠️
...oud/hypervisor/kvm/storage/KVMStorageResource.java	0.00%	2 Missing ⚠️
...e/cloudstack/network/guru/SspGuestNetworkGuru.java	0.00%	2 Missing ⚠️
...n/java/com/cloud/template/TemplateManagerImpl.java	0.00%	2 Missing ⚠️
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java	0.00%	2 Missing ⚠️
ui/src/views/offering/AddComputeOffering.vue	0.00%	2 Missing ⚠️
... and 23 more

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #8272      +/-   ##
============================================
- Coverage     29.20%   28.46%   -0.75%     
+ Complexity    31401    30456     -945     
============================================
  Files          5260     5260              
  Lines        369710   369710              
  Branches      53890    53890              
============================================
- Hits         107977   105229    -2748     
- Misses       246955   249948    +2993     
+ Partials      14778    14533     -245     

Flag	Coverage Δ
simulator-marvin-tests	24.07% <19.35%> (-0.97%)	⬇️
uitests	4.42% <0.00%> (ø)
unit-tests	14.99% <11.11%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jbampton]

@blueorangutan package

[blueorangutan]

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7843

[shwstppr]

@blueorangutan test

[blueorangutan]

@shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[DaanHoogland]

I see nothing only good language corrections here but I have two issues with the change as a whole:

1. I see some corrections in commented and possibly dead code. Those should be handled by removing them
2. I see some variable on interfaces of the system, that might give unexpected results either during or after upgrades. I'd like to see those extracted to separate commits, to facilitate testing and trouble shooting.

[blueorangutan]

[SF] Trillian test result (tid-8405)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46063 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8272-t8405-kvm-centos7.zip
Smoke tests completed. 117 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_upgrade_kubernetes_cluster	Failure	560.41	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	Failure	613.46	test_kubernetes_clusters.py

[github-actions]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[github-actions]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[DaanHoogland]

@jbampton , is this one still valid (or worth splitting up in smaller PRs)?

[jbampton]

@jbampton , is this one still valid (or worth splitting up in smaller PRs)?

Hey @DaanHoogland I think some of this is still valid but marked as draft now.

Want to get #9132 merged first before this one. But true seems there are a lot of conflicts.

Need address the "ID" problem in #9132