-
Notifications
You must be signed in to change notification settings - Fork 1.2k
default teardown methods with reversed() handling #4289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
default teardown methods with reversed() handling #4289
Conversation
|
any thoughts @GabrielBrascher @borisstoyanov @rhtyd |
|
also @vladimirpetrov |
6365e16 to
de4e4e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM based on code review.
|
@blueorangutan package |
|
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2377 |
|
@blueorangutan test |
|
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
@borisstoyanov @vladimirpetrov can you review please? |
|
Trillian test result (tid-3162)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LMGT, based on code and test results
Description
In this a small change to improve the marvin framework for resource cleanup and adding examples in the test-implementations.
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?