Skip to content

Conversation

@DaanHoogland
Copy link
Contributor

@DaanHoogland DaanHoogland commented Aug 27, 2020

Description

In this a small change to improve the marvin framework for resource cleanup and adding examples in the test-implementations.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

@DaanHoogland
Copy link
Contributor Author

any thoughts @GabrielBrascher @borisstoyanov @rhtyd

@DaanHoogland
Copy link
Contributor Author

also @vladimirpetrov

@DaanHoogland DaanHoogland reopened this Oct 14, 2020
@DaanHoogland DaanHoogland force-pushed the marvinTestImprovements branch from 6365e16 to de4e4e1 Compare October 14, 2020 12:30
@apache apache deleted a comment from blueorangutan Oct 14, 2020
@apache apache deleted a comment from blueorangutan Oct 15, 2020
@apache apache deleted a comment from blueorangutan Oct 15, 2020
@apache apache deleted a comment from blueorangutan Oct 16, 2020
@apache apache deleted a comment from blueorangutan Oct 16, 2020
@apache apache deleted a comment from blueorangutan Oct 16, 2020
@apache apache deleted a comment from blueorangutan Oct 16, 2020
@apache apache deleted a comment from blueorangutan Oct 16, 2020
@apache apache deleted a comment from blueorangutan Oct 16, 2020
@DaanHoogland DaanHoogland marked this pull request as ready for review October 16, 2020 12:40
@apache apache deleted a comment from blueorangutan Oct 19, 2020
@apache apache deleted a comment from blueorangutan Oct 19, 2020
@apache apache deleted a comment from blueorangutan Oct 19, 2020
@apache apache deleted a comment from blueorangutan Oct 19, 2020
@apache apache deleted a comment from blueorangutan Oct 19, 2020
@apache apache deleted a comment from blueorangutan Oct 19, 2020
@apache apache deleted a comment from blueorangutan Oct 20, 2020
@apache apache deleted a comment from blueorangutan Oct 20, 2020
@apache apache deleted a comment from blueorangutan Oct 20, 2020
@apache apache deleted a comment from blueorangutan Oct 20, 2020
@apache apache deleted a comment from blueorangutan Nov 11, 2020
@apache apache deleted a comment from blueorangutan Nov 11, 2020
@apache apache deleted a comment from blueorangutan Nov 11, 2020
@apache apache deleted a comment from blueorangutan Nov 11, 2020
@apache apache deleted a comment from blueorangutan Nov 11, 2020
@apache apache deleted a comment from blueorangutan Nov 11, 2020
Copy link
Member

@GabrielBrascher GabrielBrascher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on code review.

@apache apache deleted a comment from blueorangutan Nov 12, 2020
@apache apache deleted a comment from blueorangutan Nov 12, 2020
@apache apache deleted a comment from blueorangutan Nov 12, 2020
@apache apache deleted a comment from blueorangutan Nov 12, 2020
@apache apache deleted a comment from blueorangutan Nov 12, 2020
@apache apache deleted a comment from blueorangutan Nov 12, 2020
@DaanHoogland
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2377

@DaanHoogland
Copy link
Contributor Author

@blueorangutan test

@blueorangutan
Copy link

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@DaanHoogland
Copy link
Contributor Author

@borisstoyanov @vladimirpetrov can you review please?

@blueorangutan
Copy link

Trillian test result (tid-3162)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33390 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4289-t3162-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 86 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

@DaanHoogland DaanHoogland merged commit a348afe into apache:master Nov 13, 2020
@DaanHoogland DaanHoogland deleted the marvinTestImprovements branch November 13, 2020 07:56
Copy link
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LMGT, based on code and test results

@DaanHoogland DaanHoogland mentioned this pull request Aug 17, 2021
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants