Add yamllint pre-commit hook for YAML file standardization #11017
Conversation
Add yamllint hook to .pre-commit-config.yaml to standardize YAML files across the project. Created .yamllint.yml configuration with relaxed rules to accommodate existing files. Fixed colon spacing in .asf.yaml to pass yamllint checks. Closes apache#10974 Signed-off-by: vanzan01 <vanzan.1250@gmail.com>
|
Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
|
Address review comment from DaanHoogland Signed-off-by: vanzan01 <vanzan.1250@gmail.com>
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11017 +/- ##
============================================
- Coverage 16.60% 16.58% -0.03%
- Complexity 13924 14038 +114
============================================
Files 5730 5758 +28
Lines 508082 511733 +3651
Branches 61770 62216 +446
============================================
+ Hits 84388 84877 +489
- Misses 414259 417383 +3124
- Partials 9435 9473 +38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13778 |
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 13794 |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13815 |
- Move .yamllint.yml to .github/linters/ directory for better organization - Update pre-commit config to point to new location - Change file pattern to \.ya?ml$ as suggested Address review feedback from jbampton Signed-off-by: vanzan01 <vanzan.1250@gmail.com>
Co-authored-by: John Bampton <jbampton@users.noreply.github.com>
There was a problem hiding this comment.
https://github.com/apache/cloudstack/actions/runs/15782986518/job/44493446898?pr=11017
Can you fix the pre-commit workflow ?
- Remove extensive file exclusions, keep only k8s templates - Increase line length limit to 400 chars (GitHub Actions friendly) - Allow flexible colon spacing (max-spaces-after: -1) - Disable document-start requirement This provides linting value while handling infrastructure patterns. Signed-off-by: vanzan01 <vanzan.1250@gmail.com>
github-project-automation
bot
moved this from In Progress
to Done
in Apache CloudStack 4.21.0
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
@jbampton , are your concerns addressed on this PR? |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14170 |
Co-authored-by: John Bampton <jbampton@users.noreply.github.com>
Add yamllint hook to .pre-commit-config.yaml to standardize YAML files across the project. Created .yamllint.yml configuration with relaxed rules to accommodate existing files. Fixed colon spacing in .asf.yaml to pass yamllint checks.
Changes
.pre-commit-config.yaml.yamllint.ymlconfiguration with relaxed rules for existing files.asf.yamlto pass yamllint checksTest plan
Closes #10974